Skip to content

Fix GH-18986: OpenSSL backend: incorrect RAND_{load,write}_file() return value check #19013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-18986: OpenSSL backend: incorrect RAND_{load,write}_file() return value check #19013

wants to merge 1 commit into from
+2 −2

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Jul 2, 2025

As noted by the LibreSSL maintainer, these functions return -1 on error. This is further confirmed by my static analyzer that inferred the same thing for OpenSSL.

@nielsdos
Fix phpGH-18986: OpenSSL backend: incorrect RAND_{load,write}_file() …
01a4aa5 
…return value check

As noted by the LibreSSL maintainer, these functions return -1 on error.
This is further confirmed by my static analyzer that inferred the same
thing for OpenSSL.
@nielsdos nielsdos requested a review from bukka as a code owner July 2, 2025 20:05
@nielsdos nielsdos linked an issue Jul 2, 2025 that may be closed by this pull request
OpenSSL backend: incorrect RAND_load_file() return value check #18986
Closed
@nielsdos nielsdos closed this in a8086be Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bukka bukka bukka approved these changes

Assignees
No one assigned
Labels
Extension: openssl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenSSL backend: incorrect RAND_load_file() return value check
2 participants
@nielsdos @bukka